summaryrefslogtreecommitdiffstats
path: root/net/llc/sysctl_net_llc.c
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2015-01-23 20:47:00 -0500
committerDavid S. Miller <davem@davemloft.net>2015-01-25 00:23:21 -0800
commit6b8d9117ccb4f81b1244aafa7bc70ef8fa45fc49 (patch)
tree348b8723a0f41a4bffbd739c4461f68c6d21fde3 /net/llc/sysctl_net_llc.c
parent6088beef3f7517717bd21d90b379714dd0837079 (diff)
downloadop-kernel-dev-6b8d9117ccb4f81b1244aafa7bc70ef8fa45fc49.zip
op-kernel-dev-6b8d9117ccb4f81b1244aafa7bc70ef8fa45fc49.tar.gz
net: llc: use correct size for sysctl timeout entries
The timeout entries are sizeof(int) rather than sizeof(long), which means that when they were getting read we'd also leak kernel memory to userspace along with the timeout values. Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/llc/sysctl_net_llc.c')
-rw-r--r--net/llc/sysctl_net_llc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c
index 612a5dd..799bafc 100644
--- a/net/llc/sysctl_net_llc.c
+++ b/net/llc/sysctl_net_llc.c
@@ -18,28 +18,28 @@ static struct ctl_table llc2_timeout_table[] = {
{
.procname = "ack",
.data = &sysctl_llc2_ack_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_ack_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "busy",
.data = &sysctl_llc2_busy_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_busy_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "p",
.data = &sysctl_llc2_p_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_p_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "rej",
.data = &sysctl_llc2_rej_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_rej_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
OpenPOWER on IntegriCloud