diff options
| author | Mathias Krause <minipli@googlemail.com> | 2012-08-15 11:31:52 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-08-15 21:36:31 -0700 |
| commit | 04d4fbca1017c11381e7d82acea21dd741e748bc (patch) | |
| tree | a12bca825e4a2251c9acec3812a8cbfd067abec1 /net/l2tp | |
| parent | 792039c73cf176c8e39a6e8beef2c94ff46522ed (diff) | |
| download | op-kernel-dev-04d4fbca1017c11381e7d82acea21dd741e748bc.zip op-kernel-dev-04d4fbca1017c11381e7d82acea21dd741e748bc.tar.gz | |
l2tp: fix info leak via getsockname()
The L2TP code for IPv6 fails to initialize the l2tp_unused member of
struct sockaddr_l2tpip6 and that for leaks two bytes kernel stack via
the getsockname() syscall. Initialize l2tp_unused with 0 to avoid the
info leak.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp')
| -rw-r--r-- | net/l2tp/l2tp_ip6.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/l2tp/l2tp_ip6.c b/net/l2tp/l2tp_ip6.c index 35e1e4b..9275471 100644 --- a/net/l2tp/l2tp_ip6.c +++ b/net/l2tp/l2tp_ip6.c @@ -410,6 +410,7 @@ static int l2tp_ip6_getname(struct socket *sock, struct sockaddr *uaddr, lsa->l2tp_family = AF_INET6; lsa->l2tp_flowinfo = 0; lsa->l2tp_scope_id = 0; + lsa->l2tp_unused = 0; if (peer) { if (!lsk->peer_conn_id) return -ENOTCONN; |
