summaryrefslogtreecommitdiffstats
path: root/net/key
diff options
context:
space:
mode:
authorMathias Krause <minipli@googlemail.com>2013-06-26 23:52:30 +0200
committerDavid S. Miller <davem@davemloft.net>2013-06-26 15:15:54 -0700
commita5cc68f3d63306d0d288f31edfc2ae6ef8ecd887 (patch)
treea126282a827b2ff1b25c3213a4a38aecc08d84fd /net/key
parenta963a37d384d71ad43b3e9e79d68d42fbe0901f3 (diff)
downloadop-kernel-dev-a5cc68f3d63306d0d288f31edfc2ae6ef8ecd887.zip
op-kernel-dev-a5cc68f3d63306d0d288f31edfc2ae6ef8ecd887.tar.gz
af_key: fix info leaks in notify messages
key_notify_sa_flush() and key_notify_policy_flush() miss to initialize the sadb_msg_reserved member of the broadcasted message and thereby leak 2 bytes of heap memory to listeners. Fix that. Signed-off-by: Mathias Krause <minipli@googlemail.com> Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/key')
-rw-r--r--net/key/af_key.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/key/af_key.c b/net/key/af_key.c
index c5fbd75..9da8620 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -1710,6 +1710,7 @@ static int key_notify_sa_flush(const struct km_event *c)
hdr->sadb_msg_version = PF_KEY_V2;
hdr->sadb_msg_errno = (uint8_t) 0;
hdr->sadb_msg_len = (sizeof(struct sadb_msg) / sizeof(uint64_t));
+ hdr->sadb_msg_reserved = 0;
pfkey_broadcast(skb, GFP_ATOMIC, BROADCAST_ALL, NULL, c->net);
@@ -2699,6 +2700,7 @@ static int key_notify_policy_flush(const struct km_event *c)
hdr->sadb_msg_errno = (uint8_t) 0;
hdr->sadb_msg_satype = SADB_SATYPE_UNSPEC;
hdr->sadb_msg_len = (sizeof(struct sadb_msg) / sizeof(uint64_t));
+ hdr->sadb_msg_reserved = 0;
pfkey_broadcast(skb_out, GFP_ATOMIC, BROADCAST_ALL, NULL, c->net);
return 0;
OpenPOWER on IntegriCloud