diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-11-15 23:30:24 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-16 03:30:35 -0800 |
| commit | 91e9c07bd635353d1a278bdb38dbb56ac371bcb8 (patch) | |
| tree | f208f4e68fdf504fd2039b07c719ca38a2234c61 /net/key | |
| parent | e29d4363174949a7a4e46f670993d7ff43342c1c (diff) | |
| download | op-kernel-dev-91e9c07bd635353d1a278bdb38dbb56ac371bcb8.zip op-kernel-dev-91e9c07bd635353d1a278bdb38dbb56ac371bcb8.tar.gz | |
net: Fix the rollback test in dev_change_name()
net: Fix the rollback test in dev_change_name()
In dev_change_name() an err variable is used for storing the original
call_netdevice_notifiers() errno (negative) and testing for a rollback
error later, but the test for non-zero is wrong, because the err might
have positive value as well - from dev_alloc_name(). It means the
rollback for a netdevice with a number > 0 will never happen. (The err
test is reordered btw. to make it more readable.)
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/key')
0 files changed, 0 insertions, 0 deletions
