summaryrefslogtreecommitdiffstats
path: root/net/iucv/af_iucv.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-05-26 05:56:48 +0000
committerDavid S. Miller <davem@davemloft.net>2010-05-26 21:09:51 -0700
commita56635a56f2afb3d22d9ce07e8f8d69537416b2d (patch)
tree96ff391bccbc702cf2c9d74eecb055c32fb59a49 /net/iucv/af_iucv.c
parent23ecc4bde21f0ccb38f4b53cadde7fc5d67d68e3 (diff)
downloadop-kernel-dev-a56635a56f2afb3d22d9ce07e8f8d69537416b2d.zip
op-kernel-dev-a56635a56f2afb3d22d9ce07e8f8d69537416b2d.tar.gz
net/iucv: Add missing spin_unlock
Add a spin_unlock missing on the error path. There seems like no reason why the lock should continue to be held if the kzalloc fail. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * spin_unlock(E1,...); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/iucv/af_iucv.c')
-rw-r--r--net/iucv/af_iucv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index c8b4599..9637e45 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -1619,7 +1619,7 @@ static void iucv_callback_rx(struct iucv_path *path, struct iucv_message *msg)
save_message:
save_msg = kzalloc(sizeof(struct sock_msg_q), GFP_ATOMIC | GFP_DMA);
if (!save_msg)
- return;
+ goto out_unlock;
save_msg->path = path;
save_msg->msg = *msg;
OpenPOWER on IntegriCloud