summaryrefslogtreecommitdiffstats
path: root/net/irda
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-02-26 19:15:02 +0000
committerDavid S. Miller <davem@davemloft.net>2013-02-27 13:10:35 -0500
commit90c7881ecee1f08e0a49172cf61371cf2509ee4a (patch)
treec2caac0d94e2d4d75090947c2e45be0e359adb65 /net/irda
parente70ab977991964a5a7ad1182799451d067e62669 (diff)
downloadop-kernel-dev-90c7881ecee1f08e0a49172cf61371cf2509ee4a.zip
op-kernel-dev-90c7881ecee1f08e0a49172cf61371cf2509ee4a.tar.gz
irda: small read beyond end of array in debug code
charset comes from skb->data. It's a number in the 0-255 range. If we have debugging turned on then this could cause a read beyond the end of the array. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda')
-rw-r--r--net/irda/iriap.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/net/irda/iriap.c b/net/irda/iriap.c
index e71e85b..29340a9 100644
--- a/net/irda/iriap.c
+++ b/net/irda/iriap.c
@@ -495,8 +495,11 @@ static void iriap_getvaluebyclass_confirm(struct iriap_cb *self,
/* case CS_ISO_8859_9: */
/* case CS_UNICODE: */
default:
- IRDA_DEBUG(0, "%s(), charset %s, not supported\n",
- __func__, ias_charset_types[charset]);
+ IRDA_DEBUG(0, "%s(), charset [%d] %s, not supported\n",
+ __func__, charset,
+ charset < ARRAY_SIZE(ias_charset_types) ?
+ ias_charset_types[charset] :
+ "(unknown)");
/* Aborting, close connection! */
iriap_disconnect_request(self);
OpenPOWER on IntegriCloud