summaryrefslogtreecommitdiffstats
path: root/net/irda
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2012-10-04 20:01:21 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-05 09:26:01 -0700
commit6f5601251d7e306b8a7bf5e674c5307d865c0fa1 (patch)
tree55f3e550181d02ecc8dfe7d09a292c98ece96469 /net/irda
parentecefbd94b834fa32559d854646d777c56749ef1c (diff)
downloadop-kernel-dev-6f5601251d7e306b8a7bf5e674c5307d865c0fa1.zip
op-kernel-dev-6f5601251d7e306b8a7bf5e674c5307d865c0fa1.tar.gz
net, TTY: initialize tty->driver_data before usage
Commit 9c650ffc ("TTY: ircomm_tty, add tty install") split _open() to _install() and _open(). It also moved the initialization of driver_data out of open(), but never added it to install() - causing a NULL ptr deref whenever the driver was used. Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Acked-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/irda')
-rw-r--r--net/irda/ircomm/ircomm_tty.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c
index 95a3a7a..496ce2c 100644
--- a/net/irda/ircomm/ircomm_tty.c
+++ b/net/irda/ircomm/ircomm_tty.c
@@ -421,6 +421,8 @@ static int ircomm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
hashbin_insert(ircomm_tty, (irda_queue_t *) self, line, NULL);
}
+ tty->driver_data = self;
+
return tty_port_install(&self->port, driver, tty);
}
OpenPOWER on IntegriCloud