diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2009-05-19 15:27:55 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-05-19 15:36:16 -0700 |
| commit | fd2120ca0da9108e53f8db2fe57ab74fca76fd56 (patch) | |
| tree | 814d647ba22780f741caa119c7c4a81f81bb3695 /net/irda/irnetlink.c | |
| parent | e5488ce56995e987a0cf9689e190b712a616a980 (diff) | |
| download | op-kernel-dev-fd2120ca0da9108e53f8db2fe57ab74fca76fd56.zip op-kernel-dev-fd2120ca0da9108e53f8db2fe57ab74fca76fd56.tar.gz | |
net: use NLMSG_DEFAULT_SIZE in nlmsg_new() allocations
nlmsg_new() adds the size of the netlink header to the value
that has been passed as parameter. If NLMSG_GOODSIZE is selected,
we request an allocation of one memory page plus the size of the
header. Instead, NLMSG_DEFAULT_SIZE should be used since it
already substracts the size of the Netlink header.
I have the impression that the similar naming in both constant
is error prone when using it with nlmsg_new(). This is already
documented in include/net/netlink.h
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda/irnetlink.c')
| -rw-r--r-- | net/irda/irnetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c index 2f05ec1..82c6118 100644 --- a/net/irda/irnetlink.c +++ b/net/irda/irnetlink.c @@ -87,7 +87,7 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info) if (!dev) return -ENODEV; - msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); + msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); if (!msg) { dev_put(dev); return -ENOMEM; |
