summaryrefslogtreecommitdiffstats
path: root/net/irda/ircomm
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2011-05-19 18:58:39 -0400
committerDavid S. Miller <davem@davemloft.net>2011-05-19 18:58:39 -0400
commit8ce6eb1a4a4bc46820f23e927377d386d3ec5404 (patch)
tree03365bd164a28786402539083147041a2864525f /net/irda/ircomm
parentad6376434c945495ea8c4082ad8a392cc58c3406 (diff)
downloadop-kernel-dev-8ce6eb1a4a4bc46820f23e927377d386d3ec5404.zip
op-kernel-dev-8ce6eb1a4a4bc46820f23e927377d386d3ec5404.tar.gz
irda: Fix error propagation in ircomm_lmp_connect_response()
The variable 'ret' is set but unused, and this pointed out that errors from irlmp_connect_response() are not propagated to the caller. Note that this is currently academic since irlmp_connect_response() always returns 0. :-) Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda/ircomm')
-rw-r--r--net/irda/ircomm/ircomm_lmp.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/net/irda/ircomm/ircomm_lmp.c b/net/irda/ircomm/ircomm_lmp.c
index 08fb54d..3b8095c 100644
--- a/net/irda/ircomm/ircomm_lmp.c
+++ b/net/irda/ircomm/ircomm_lmp.c
@@ -75,7 +75,6 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self,
struct sk_buff *userdata)
{
struct sk_buff *tx_skb;
- int ret;
IRDA_DEBUG(0, "%s()\n", __func__ );
@@ -100,9 +99,7 @@ static int ircomm_lmp_connect_response(struct ircomm_cb *self,
tx_skb = userdata;
}
- ret = irlmp_connect_response(self->lsap, tx_skb);
-
- return 0;
+ return irlmp_connect_response(self->lsap, tx_skb);
}
static int ircomm_lmp_disconnect_request(struct ircomm_cb *self,
OpenPOWER on IntegriCloud