diff options
| author | David L Stevens <dlstevens@us.ibm.com> | 2007-01-04 12:31:14 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-01-04 12:31:14 -0800 |
| commit | 30c4cf577fb5b68c16e5750d6bdbd7072e42b279 (patch) | |
| tree | 36f558c08ebdd1830536aab92b8abac79330cdbc /net/ipv6 | |
| parent | 0d630cc0a6cb8ad544b5913a26ff1349ed7c8587 (diff) | |
| download | op-kernel-dev-30c4cf577fb5b68c16e5750d6bdbd7072e42b279.zip op-kernel-dev-30c4cf577fb5b68c16e5750d6bdbd7072e42b279.tar.gz | |
[IPV4/IPV6]: Fix inet{,6} device initialization order.
It is important that we only assign dev->ip{,6}_ptr
only after all portions of the inet{,6} are setup.
Otherwise we can receive packets before the multicast
spinlocks et al. are initialized.
Signed-off-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
| -rw-r--r-- | net/ipv6/addrconf.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 9b0a906..171e5b5 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -413,8 +413,6 @@ static struct inet6_dev * ipv6_add_dev(struct net_device *dev) if (netif_carrier_ok(dev)) ndev->if_flags |= IF_READY; - /* protected by rtnl_lock */ - rcu_assign_pointer(dev->ip6_ptr, ndev); ipv6_mc_init_dev(ndev); ndev->tstamp = jiffies; @@ -425,6 +423,8 @@ static struct inet6_dev * ipv6_add_dev(struct net_device *dev) NULL); addrconf_sysctl_register(ndev, &ndev->cnf); #endif + /* protected by rtnl_lock */ + rcu_assign_pointer(dev->ip6_ptr, ndev); return ndev; } |
