diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-09-16 16:24:44 -0700 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 16:51:24 -0700 |
| commit | 0cfad07555312468296ea3bbbcdf99038f58678b (patch) | |
| tree | a95c432bcafaf22e965dcaf27bfd4a61723d1d64 /net/ipv4 | |
| parent | 007e3936bdaaa012483c9fe06ca71c272458c710 (diff) | |
| download | op-kernel-dev-0cfad07555312468296ea3bbbcdf99038f58678b.zip op-kernel-dev-0cfad07555312468296ea3bbbcdf99038f58678b.tar.gz | |
[NETLINK]: Avoid pointer in netlink_run_queue
I was looking at Patrick's fix to inet_diag and it occured
to me that we're using a pointer argument to return values
unnecessarily in netlink_run_queue. Changing it to return
the value will allow the compiler to generate better code
since the value won't have to be memory-backed.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/inet_diag.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 031cc48..b04a6ee 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c @@ -845,7 +845,7 @@ static void inet_diag_rcv(struct sock *sk, int len) do { mutex_lock(&inet_diag_mutex); - netlink_run_queue(sk, &qlen, &inet_diag_rcv_msg); + qlen = netlink_run_queue(sk, qlen, &inet_diag_rcv_msg); mutex_unlock(&inet_diag_mutex); } while (qlen); } |
