diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-05-15 05:43:20 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-05-15 16:57:47 -0400 |
| commit | 4929fd8cb064e1bbee76b8c4cf6bd3f0e40bf66e (patch) | |
| tree | 809220d1b1d584f4b451c737e2ffedc712a3c969 /net/ipv4 | |
| parent | 688c3b003382c16be811072b4c6e88408672861c (diff) | |
| download | op-kernel-dev-4929fd8cb064e1bbee76b8c4cf6bd3f0e40bf66e.zip op-kernel-dev-4929fd8cb064e1bbee76b8c4cf6bd3f0e40bf66e.tar.gz | |
ip_tunnel: delete unneeded call to netdev_priv
Netdev_priv is an accessor function, and has no purpose if its result is
not used.
A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/ip_tunnel.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index b3f8597..059176d 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -395,11 +395,10 @@ static struct ip_tunnel *ip_tunnel_create(struct net *net, struct ip_tunnel_net *itn, struct ip_tunnel_parm *parms) { - struct ip_tunnel *nt, *fbt; + struct ip_tunnel *nt; struct net_device *dev; BUG_ON(!itn->fb_tunnel_dev); - fbt = netdev_priv(itn->fb_tunnel_dev); dev = __ip_tunnel_create(net, itn->fb_tunnel_dev->rtnl_link_ops, parms); if (IS_ERR(dev)) return ERR_CAST(dev); |
