diff options
author | Guenter Roeck <linux@roeck-us.net> | 2014-05-14 13:12:49 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-05-15 22:56:43 -0400 |
commit | b394745df2d9d4c30bf1bcc55773bec6f3bc7c67 (patch) | |
tree | c5f811a57b3051b3f63d3276604447ddff6ec33b /net/ipv4/ip_vti.c | |
parent | 48f0459fb766415b63ba0e65d528262a9c23b4f7 (diff) | |
download | op-kernel-dev-b394745df2d9d4c30bf1bcc55773bec6f3bc7c67.zip op-kernel-dev-b394745df2d9d4c30bf1bcc55773bec6f3bc7c67.tar.gz |
net: phy: Don't call phy_resume if phy_init_hw failed
After the call to phy_init_hw failed in phy_attach_direct, phy_detach is called
to detach the phy device from its network device. If the attached driver is a
generic phy driver, this also detaches the driver. Subsequently phy_resume
is called, which assumes without checking that a driver is attached to the
device. This will result in a crash such as
Unable to handle kernel paging request for data at address 0xffffffffffffff90
Faulting instruction address: 0xc0000000003a0e18
Oops: Kernel access of bad area, sig: 11 [#1]
...
NIP [c0000000003a0e18] .phy_attach_direct+0x68/0x17c
LR [c0000000003a0e6c] .phy_attach_direct+0xbc/0x17c
Call Trace:
[c0000003fc0475d0] [c0000000003a0e6c] .phy_attach_direct+0xbc/0x17c (unreliable)
[c0000003fc047670] [c0000000003a0ff8] .phy_connect_direct+0x28/0x98
[c0000003fc047700] [c0000000003f0074] .of_phy_connect+0x4c/0xa4
Only call phy_resume if phy_init_hw was successful.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_vti.c')
0 files changed, 0 insertions, 0 deletions