diff options
author | Anthoine Bourgeois <anthoine.bourgeois@blade-group.com> | 2018-04-29 22:05:58 +0000 |
---|---|---|
committer | Radim Krčmář <rkrcmar@redhat.com> | 2018-05-05 23:09:39 +0200 |
commit | ecf08dad723d3e000aecff6c396f54772d124733 (patch) | |
tree | c0f4b7e44b31b2acf06f5273f92fd23cc868ba03 /net/hsr/hsr_framereg.c | |
parent | f3351c609bbdcf3c519ff5c5451103aa48a5b804 (diff) | |
download | op-kernel-dev-ecf08dad723d3e000aecff6c396f54772d124733.zip op-kernel-dev-ecf08dad723d3e000aecff6c396f54772d124733.tar.gz |
KVM: x86: remove APIC Timer periodic/oneshot spikes
Since the commit "8003c9ae204e: add APIC Timer periodic/oneshot mode VMX
preemption timer support", a Windows 10 guest has some erratic timer
spikes.
Here the results on a 150000 times 1ms timer without any load:
Before 8003c9ae204e | After 8003c9ae204e
Max 1834us | 86000us
Mean 1100us | 1021us
Deviation 59us | 149us
Here the results on a 150000 times 1ms timer with a cpu-z stress test:
Before 8003c9ae204e | After 8003c9ae204e
Max 32000us | 140000us
Mean 1006us | 1997us
Deviation 140us | 11095us
The root cause of the problem is starting hrtimer with an expiry time
already in the past can take more than 20 milliseconds to trigger the
timer function. It can be solved by forward such past timers
immediately, rather than submitting them to hrtimer_start().
In case the timer is periodic, update the target expiration and call
hrtimer_start with it.
v2: Check if the tsc deadline is already expired. Thank you Mika.
v3: Execute the past timers immediately rather than submitting them to
hrtimer_start().
v4: Rearm the periodic timer with advance_periodic_target_expiration() a
simpler version of set_target_expiration(). Thank you Paolo.
Cc: Mika Penttilä <mika.penttila@nextfour.com>
Cc: Wanpeng Li <kernellwp@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
8003c9ae204e ("KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support")
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Diffstat (limited to 'net/hsr/hsr_framereg.c')
0 files changed, 0 insertions, 0 deletions