summaryrefslogtreecommitdiffstats
path: root/net/decnet
diff options
context:
space:
mode:
authorGustavo A. R. Silva <garsilva@embeddedor.com>2017-10-28 15:39:48 -0500
committerDavid S. Miller <davem@davemloft.net>2017-11-01 12:05:49 +0900
commit3a7943ba5b7763488753305fddb0a50e911e0617 (patch)
tree621be74459ec11618ef4f45556b8bb9531dc1f53 /net/decnet
parent68ad08c4f8ee6254ab814d15b9765f7f82ed0ae7 (diff)
downloadop-kernel-dev-3a7943ba5b7763488753305fddb0a50e911e0617.zip
op-kernel-dev-3a7943ba5b7763488753305fddb0a50e911e0617.tar.gz
net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet')
-rw-r--r--net/decnet/dn_nsp_out.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/net/decnet/dn_nsp_out.c b/net/decnet/dn_nsp_out.c
index e50a4ad..56a52a0 100644
--- a/net/decnet/dn_nsp_out.c
+++ b/net/decnet/dn_nsp_out.c
@@ -313,11 +313,8 @@ static __le16 *dn_mk_ack_header(struct sock *sk, struct sk_buff *skb, unsigned c
ackcrs |= 0x8000;
/* If this is an "other data/ack" message, swap acknum and ackcrs */
- if (other) {
- unsigned short tmp = acknum;
- acknum = ackcrs;
- ackcrs = tmp;
- }
+ if (other)
+ swap(acknum, ackcrs);
/* Set "cross subchannel" bit in ackcrs */
ackcrs |= 0x2000;
OpenPOWER on IntegriCloud