diff options
| author | Gerrit Renker <gerrit@erg.abdn.ac.uk> | 2006-11-10 12:32:01 -0200 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-12-02 21:21:58 -0800 |
| commit | 8a73cd09d96aa01743316657fc4e6864fe79b703 (patch) | |
| tree | fa22ed8ac78c5c76cc8ee3afd8bf72607290d42d /net/dccp/minisocks.c | |
| parent | f6484f7c7ad22e4bb018875c386d6a7aaa441426 (diff) | |
| download | op-kernel-dev-8a73cd09d96aa01743316657fc4e6864fe79b703.zip op-kernel-dev-8a73cd09d96aa01743316657fc4e6864fe79b703.tar.gz | |
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
This patch removes two functions, the send_ack functions of request_sock,
which are not called/used by the DCCP code. It is correct that these
functions are not called, below is a justification why calling these
functions (on a passive socket in the LISTEN/RESPOND state) would mean
a DCCP protocol violation.
A) Background: using request_sock in TCP:
Diffstat (limited to 'net/dccp/minisocks.c')
| -rw-r--r-- | net/dccp/minisocks.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c index 9045438..5f3e1a4 100644 --- a/net/dccp/minisocks.c +++ b/net/dccp/minisocks.c @@ -11,6 +11,7 @@ */ #include <linux/dccp.h> +#include <linux/kernel.h> #include <linux/skbuff.h> #include <linux/timer.h> @@ -283,3 +284,12 @@ int dccp_child_process(struct sock *parent, struct sock *child, } EXPORT_SYMBOL_GPL(dccp_child_process); + +void dccp_reqsk_send_ack(struct sk_buff *skb, struct request_sock *rsk) +{ + pr_info(KERN_WARNING "DCCP: ACK packets are never sent in " + "LISTEN/RESPOND state\n"); + dump_stack(); +} + +EXPORT_SYMBOL_GPL(dccp_reqsk_send_ack); |
