diff options
| author | Andreas Henriksson <andreas@fatal.se> | 2013-11-07 18:26:38 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-08 14:53:10 -0500 |
| commit | 13eb2ab2d33c57ebddc57437a7d341995fc9138c (patch) | |
| tree | 909a64b9d64f47c10060791ab351740ca9c6ecd8 /net/core | |
| parent | 394055f6fabd077e74815865f01a73a31dd765d3 (diff) | |
| download | op-kernel-dev-13eb2ab2d33c57ebddc57437a7d341995fc9138c.zip op-kernel-dev-13eb2ab2d33c57ebddc57437a7d341995fc9138c.tar.gz | |
net: Fix "ip rule delete table 256"
When trying to delete a table >= 256 using iproute2 the local table
will be deleted.
The table id is specified as a netlink attribute when it needs more then
8 bits and iproute2 then sets the table field to RT_TABLE_UNSPEC (0).
Preconditions to matching the table id in the rule delete code
doesn't seem to take the "table id in netlink attribute" into condition
so the frh_get_table helper function never gets to do its job when
matching against current rule.
Use the helper function twice instead of peaking at the table value directly.
Originally reported at: http://bugs.debian.org/724783
Reported-by: Nicolas HICHER <nhicher@avencall.com>
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/fib_rules.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 2e65413..f409e0b 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -460,7 +460,8 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh) if (frh->action && (frh->action != rule->action)) continue; - if (frh->table && (frh_get_table(frh, tb) != rule->table)) + if (frh_get_table(frh, tb) && + (frh_get_table(frh, tb) != rule->table)) continue; if (tb[FRA_PRIORITY] && |
