summaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@vyatta.com>2010-08-01 00:33:23 -0700
committerDavid S. Miller <davem@davemloft.net>2010-08-01 00:33:23 -0700
commitde38483010bae523f533bb6bf9f7b7353772f6eb (patch)
treeee31326ffb81541496ca960a9fbfa8a92a13d26c /net/core
parente2e0c7c9ddbe6b79fe647aca5eea3a405d38ada4 (diff)
downloadop-kernel-dev-de38483010bae523f533bb6bf9f7b7353772f6eb.zip
op-kernel-dev-de38483010bae523f533bb6bf9f7b7353772f6eb.tar.gz
net: ingress filter message limit
If user misconfigures ingress and causes a redirection loop, don't overwhelm the log. This is also a error case so make it unlikely. Found by inspection, luckily not in real system. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/dev.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index b74fcd3..5d1282d 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2646,10 +2646,10 @@ static int ing_filter(struct sk_buff *skb)
int result = TC_ACT_OK;
struct Qdisc *q;
- if (MAX_RED_LOOP < ttl++) {
- printk(KERN_WARNING
- "Redir loop detected Dropping packet (%d->%d)\n",
- skb->skb_iif, dev->ifindex);
+ if (unlikely(MAX_RED_LOOP < ttl++)) {
+ if (net_ratelimit())
+ pr_warning( "Redir loop detected Dropping packet (%d->%d)\n",
+ skb->skb_iif, dev->ifindex);
return TC_ACT_SHOT;
}
OpenPOWER on IntegriCloud