summaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2006-08-01 00:00:12 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2006-08-02 13:38:30 -0700
commitb60dfc6c20bd5f19de0083362ce377c89b1e5a24 (patch)
treef085ddb2e7c99d6e753b0fe7b973569a17ceefee /net/core
parent3ab720881b6e36bd5190a3a11cee8d8d067c4ad7 (diff)
downloadop-kernel-dev-b60dfc6c20bd5f19de0083362ce377c89b1e5a24.zip
op-kernel-dev-b60dfc6c20bd5f19de0083362ce377c89b1e5a24.tar.gz
[NET]: Kill the WARN_ON() calls for checksum fixups.
We have a more complete solution in the works, involving the seperation of CHECKSUM_HW on input vs. output, and having netfilter properly do incremental checksums. But that is a very involved patch and is thus 2.6.19 material. What we have now is infinitely better than the past, wherein all TSO packets were dropped due to corrupt checksums as soon at the NAT module was loaded. At least now, the checksums do get fixed up, it just isn't the cleanest nor most optimal solution. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/dev.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 4d2b516..5b630ce 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1166,11 +1166,6 @@ int skb_checksum_help(struct sk_buff *skb, int inward)
goto out_set_summed;
if (unlikely(skb_shinfo(skb)->gso_size)) {
- static int warned;
-
- WARN_ON(!warned);
- warned = 1;
-
/* Let GSO fix up the checksum. */
goto out_set_summed;
}
@@ -1220,11 +1215,6 @@ struct sk_buff *skb_gso_segment(struct sk_buff *skb, int features)
__skb_pull(skb, skb->mac_len);
if (unlikely(skb->ip_summed != CHECKSUM_HW)) {
- static int warned;
-
- WARN_ON(!warned);
- warned = 1;
-
if (skb_header_cloned(skb) &&
(err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC)))
return ERR_PTR(err);
OpenPOWER on IntegriCloud