diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-03 20:46:48 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 15:00:36 -0800 |
| commit | 65f7651788e18fadb2fbb7276af935d7871e1803 (patch) | |
| tree | dcad32d4344d6d11d80061773d9d1dbc9ae92223 /net/core/sock.c | |
| parent | 571e7682026fd0e25833d103a3eeb74be29bf199 (diff) | |
| download | op-kernel-dev-65f7651788e18fadb2fbb7276af935d7871e1803.zip op-kernel-dev-65f7651788e18fadb2fbb7276af935d7871e1803.tar.gz | |
[NET]: prot_inuse cleanups and optimizations
1) Cleanups (all functions are prefixed by sock_prot_inuse)
sock_prot_inc_use(prot) -> sock_prot_inuse_add(prot,-1)
sock_prot_dec_use(prot) -> sock_prot_inuse_add(prot,-1)
sock_prot_inuse() -> sock_prot_inuse_get()
New functions :
sock_prot_inuse_init() and sock_prot_inuse_free() to abstract pcounter use.
2) if CONFIG_PROC_FS=n, we can zap 'inuse' member from "struct proto",
since nobody wants to read the inuse value.
This saves 1372 bytes on i386/SMP and some cpu cycles.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/sock.c')
| -rw-r--r-- | net/core/sock.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/core/sock.c b/net/core/sock.c index 3d7757e..1c4b1cd 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1913,7 +1913,7 @@ int proto_register(struct proto *prot, int alloc_slab) char *request_sock_slab_name = NULL; char *timewait_sock_slab_name; - if (pcounter_alloc(&prot->inuse) != 0) { + if (sock_prot_inuse_init(prot) != 0) { printk(KERN_CRIT "%s: Can't alloc inuse counters!\n", prot->name); goto out; } @@ -1984,7 +1984,7 @@ out_free_sock_slab: kmem_cache_destroy(prot->slab); prot->slab = NULL; out_free_inuse: - pcounter_free(&prot->inuse); + sock_prot_inuse_free(prot); out: return -ENOBUFS; } @@ -1997,7 +1997,7 @@ void proto_unregister(struct proto *prot) list_del(&prot->node); write_unlock(&proto_list_lock); - pcounter_free(&prot->inuse); + sock_prot_inuse_free(prot); if (prot->slab != NULL) { kmem_cache_destroy(prot->slab); |
