diff options
| author | Jarek Poplawski <jarkao2@gmail.com> | 2009-02-12 16:51:43 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-12 16:51:43 -0800 |
| commit | ce3dd39595d9d64f4ba6ee8dd24c6269a3b56b6a (patch) | |
| tree | 8efc1a3d7239b37ffd7f51851fc3b4bf734c6c02 /net/core/skbuff.c | |
| parent | 51621fbdb1ea8709ab67170b54e71be6d9fa29ad (diff) | |
| download | op-kernel-dev-ce3dd39595d9d64f4ba6ee8dd24c6269a3b56b6a.zip op-kernel-dev-ce3dd39595d9d64f4ba6ee8dd24c6269a3b56b6a.tar.gz | |
net: Fix page seeking for skb_splice_bits().
struct page walking should be done with proper accessor functions, not
directly.
With doubts from David S. Miller and Herbert Xu.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/skbuff.c')
| -rw-r--r-- | net/core/skbuff.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 7657cec..ab7d2e9 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1412,8 +1412,13 @@ static inline int spd_fill_page(struct splice_pipe_desc *spd, struct page *page, static inline void __segment_seek(struct page **page, unsigned int *poff, unsigned int *plen, unsigned int off) { + unsigned long n; + *poff += off; - *page += *poff / PAGE_SIZE; + n = *poff / PAGE_SIZE; + if (n) + *page = nth_page(*page, n); + *poff = *poff % PAGE_SIZE; *plen -= off; } |
