diff options
author | WANG Cong <xiyou.wangcong@gmail.com> | 2015-03-31 11:01:46 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-04-02 20:52:34 -0400 |
commit | 419df12fb5fa558451319276838c1842f2b11f8f (patch) | |
tree | 711c055fc40c8972b9f3cf91c572a00ca80ed7cb /net/core/fib_rules.c | |
parent | ed785309c94445dd90e242370e1f7bb034e008fd (diff) | |
download | op-kernel-dev-419df12fb5fa558451319276838c1842f2b11f8f.zip op-kernel-dev-419df12fb5fa558451319276838c1842f2b11f8f.tar.gz |
net: move fib_rules_unregister() under rtnl lock
We have to hold rtnl lock for fib_rules_unregister()
otherwise the following race could happen:
fib_rules_unregister(): fib_nl_delrule():
... ...
... ops = lookup_rules_ops();
list_del_rcu(&ops->list);
list_for_each_entry(ops->rules) {
fib_rules_cleanup_ops(ops); ...
list_del_rcu(); list_del_rcu();
}
Note, net->rules_mod_lock is actually not needed at all,
either upper layer netns code or rtnl lock guarantees
we are safe.
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/fib_rules.c')
-rw-r--r-- | net/core/fib_rules.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 44706e8..e4fdc9d 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -175,9 +175,9 @@ void fib_rules_unregister(struct fib_rules_ops *ops) spin_lock(&net->rules_mod_lock); list_del_rcu(&ops->list); - fib_rules_cleanup_ops(ops); spin_unlock(&net->rules_mod_lock); + fib_rules_cleanup_ops(ops); call_rcu(&ops->rcu, fib_rules_put_rcu); } EXPORT_SYMBOL_GPL(fib_rules_unregister); |