diff options
| author | Marek Lindner <lindner_marek@yahoo.de> | 2011-02-10 14:33:53 +0000 |
|---|---|---|
| committer | Marek Lindner <lindner_marek@yahoo.de> | 2011-03-05 12:50:03 +0100 |
| commit | 44524fcdf6ca19b58c24f7622c4af1d8d8fe59f8 (patch) | |
| tree | 297c76f80d68d56e3c65a23c70de645a1c93df47 /net/batman-adv/types.h | |
| parent | a4c135c561106c397bae33455acfca4aa8065a30 (diff) | |
| download | op-kernel-dev-44524fcdf6ca19b58c24f7622c4af1d8d8fe59f8.zip op-kernel-dev-44524fcdf6ca19b58c24f7622c4af1d8d8fe59f8.tar.gz | |
batman-adv: Correct rcu refcounting for neigh_node
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Diffstat (limited to 'net/batman-adv/types.h')
| -rw-r--r-- | net/batman-adv/types.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 1f833f0..084604a 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -117,9 +117,8 @@ struct neigh_node { struct list_head bonding_list; unsigned long last_valid; unsigned long real_bits[NUM_WORDS]; - struct kref refcount; + atomic_t refcount; struct rcu_head rcu; - struct rcu_head rcu_bond; struct orig_node *orig_node; struct batman_if *if_incoming; }; |
