summaryrefslogtreecommitdiffstats
path: root/net/batman-adv/routing.c
diff options
context:
space:
mode:
authorAntonio Quartulli <ordex@autistici.org>2011-05-08 20:52:57 +0200
committerSven Eckelmann <sven@narfation.org>2011-05-30 07:39:27 +0200
commite2cbc11c0e1225bd5fe183a967fc80df3db10745 (patch)
tree5e7bf4845b660067fdfb93e4cee836fa545a621f /net/batman-adv/routing.c
parent55922c9d1b84b89cb946c777fddccb3247e7df2c (diff)
downloadop-kernel-dev-e2cbc11c0e1225bd5fe183a967fc80df3db10745.zip
op-kernel-dev-e2cbc11c0e1225bd5fe183a967fc80df3db10745.tar.gz
batman-adv: move neigh_node->if_incoming->if_status check in find_router()
Every time that find_router() is invoked, if_status has to be compared with IF_ACTIVE. Moving this comparison inside find_router() will avoid to write it each time. Signed-off-by: Antonio Quartulli <ordex@autistici.org> Signed-off-by: Sven Eckelmann <sven@narfation.org>
Diffstat (limited to 'net/batman-adv/routing.c')
-rw-r--r--net/batman-adv/routing.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index bb1c3ec..8c403ce 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -1240,6 +1240,9 @@ struct neigh_node *find_router(struct bat_priv *bat_priv,
router = find_ifalter_router(primary_orig_node, recv_if);
return_router:
+ if (router && router->if_incoming->if_status != IF_ACTIVE)
+ goto err_unlock;
+
rcu_read_unlock();
return router;
err_unlock:
OpenPOWER on IntegriCloud