diff options
| author | Linus Lüssing <linus.luessing@web.de> | 2013-04-15 21:43:29 +0800 |
|---|---|---|
| committer | Antonio Quartulli <ordex@autistici.org> | 2013-05-17 09:54:28 +0200 |
| commit | 72822225bd41320a98f5d7cde38317766e18983f (patch) | |
| tree | c1947655ac129d0a1aa3212755097baa9600bb3e /net/batman-adv/originator.h | |
| parent | b0ce3508b25ea6fa10ae3ca254de1d695b521702 (diff) | |
| download | op-kernel-dev-72822225bd41320a98f5d7cde38317766e18983f.zip op-kernel-dev-72822225bd41320a98f5d7cde38317766e18983f.tar.gz | |
batman-adv: Fix rcu_barrier() miss due to double call_rcu() in TT code
rcu_barrier() only waits for the currently scheduled rcu functions
to finish - it won't wait for any function scheduled via another
call_rcu() within an rcu scheduled function.
Unfortunately our batadv_tt_orig_list_entry_free_ref() does just that,
via a batadv_orig_node_free_ref() call, leading to our rcu_barrier()
call potentially missing such a batadv_orig_node_free_ref().
This patch fixes this issue by calling the batadv_orig_node_free_rcu()
directly from the rcu callback, removing the unnecessary, additional
call_rcu() layer here.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Acked-by: Antonio Quartulli <ordex@autistici.org>
Diffstat (limited to 'net/batman-adv/originator.h')
| -rw-r--r-- | net/batman-adv/originator.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h index 7df48fa..734e5a3 100644 --- a/net/batman-adv/originator.h +++ b/net/batman-adv/originator.h @@ -26,6 +26,7 @@ int batadv_originator_init(struct batadv_priv *bat_priv); void batadv_originator_free(struct batadv_priv *bat_priv); void batadv_purge_orig_ref(struct batadv_priv *bat_priv); void batadv_orig_node_free_ref(struct batadv_orig_node *orig_node); +void batadv_orig_node_free_ref_now(struct batadv_orig_node *orig_node); struct batadv_orig_node *batadv_get_orig_node(struct batadv_priv *bat_priv, const uint8_t *addr); struct batadv_neigh_node * |
