diff options
| author | Sven Eckelmann <sven@narfation.org> | 2012-08-20 23:37:26 +0200 |
|---|---|---|
| committer | Antonio Quartulli <ordex@autistici.org> | 2012-10-29 09:42:36 +0100 |
| commit | bd5b80d51a6c4a68f7d4b9b92c495329f47e53d4 (patch) | |
| tree | 8650acb5b824f001651186e1357f4b7666437330 /net/batman-adv/debugfs.c | |
| parent | 8e7c15d6b5468f0dcdd887db1e5df88e629c00d6 (diff) | |
| download | op-kernel-dev-bd5b80d51a6c4a68f7d4b9b92c495329f47e53d4.zip op-kernel-dev-bd5b80d51a6c4a68f7d4b9b92c495329f47e53d4.tar.gz | |
batman-adv: Check return value of try_module_get
New operations should not be started when they need an increased module
reference counter and try_module_get failed.
This patch addresses Coverity #712284: Unchecked return value
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Diffstat (limited to 'net/batman-adv/debugfs.c')
| -rw-r--r-- | net/batman-adv/debugfs.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c index 391d4fb..bd032bc 100644 --- a/net/batman-adv/debugfs.c +++ b/net/batman-adv/debugfs.c @@ -99,15 +99,17 @@ int batadv_debug_log(struct batadv_priv *bat_priv, const char *fmt, ...) static int batadv_log_open(struct inode *inode, struct file *file) { + if (!try_module_get(THIS_MODULE)) + return -EBUSY; + nonseekable_open(inode, file); file->private_data = inode->i_private; - batadv_inc_module_count(); return 0; } static int batadv_log_release(struct inode *inode, struct file *file) { - batadv_dec_module_count(); + module_put(THIS_MODULE); return 0; } |
