diff options
author | Mathias Krause <minipli@googlemail.com> | 2012-08-15 11:31:45 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-08-15 21:36:30 -0700 |
commit | 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a (patch) | |
tree | 11bb3194625ed6bc0a169f39b2a802b5ff7c699d /net/atm/pvc.c | |
parent | e862f1a9b7df4e8196ebec45ac62295138aa3fc2 (diff) | |
download | op-kernel-dev-3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a.zip op-kernel-dev-3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a.tar.gz |
atm: fix info leak via getsockname()
The ATM code fails to initialize the two padding bytes of struct
sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
before filling the structure to avoid the info leak.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm/pvc.c')
-rw-r--r-- | net/atm/pvc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/atm/pvc.c b/net/atm/pvc.c index 3a73491..ae03240 100644 --- a/net/atm/pvc.c +++ b/net/atm/pvc.c @@ -95,6 +95,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr, return -ENOTCONN; *sockaddr_len = sizeof(struct sockaddr_atmpvc); addr = (struct sockaddr_atmpvc *)sockaddr; + memset(addr, 0, sizeof(*addr)); addr->sap_family = AF_ATMPVC; addr->sap_addr.itf = vcc->dev->number; addr->sap_addr.vpi = vcc->vpi; |