summaryrefslogtreecommitdiffstats
path: root/net/9p
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-07-10 11:51:54 +0200
committerEric Van Hensbergen <ericvh@gmail.com>2010-08-02 10:37:17 -0500
commitcff6b8a9b81b404e8ce0257b26007c3afe625212 (patch)
tree8d8793de1843a1831f5ee38efb273a30f06c2a65 /net/9p
parentb126468e08d92aaeffa58ef04d70e417241dadc1 (diff)
downloadop-kernel-dev-cff6b8a9b81b404e8ce0257b26007c3afe625212.zip
op-kernel-dev-cff6b8a9b81b404e8ce0257b26007c3afe625212.tar.gz
9p: strlen() doesn't count the terminator
This is an off by one bug because strlen() doesn't count the NULL terminator. We strcpy() addr into a fixed length array of size UNIX_PATH_MAX later on. The addr variable is the name of the device being mounted. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Diffstat (limited to 'net/9p')
-rw-r--r--net/9p/trans_fd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 98ce9bc..c85109d 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args)
csocket = NULL;
- if (strlen(addr) > UNIX_PATH_MAX) {
+ if (strlen(addr) >= UNIX_PATH_MAX) {
P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n",
addr);
return -ENAMETOOLONG;
OpenPOWER on IntegriCloud