diff options
author | Tuomas Tynkkynen <tuomas@tuxera.com> | 2017-09-06 17:59:08 +0300 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2017-10-23 23:10:01 -0400 |
commit | 9523feac272ccad2ad8186ba4fcc89103754de52 (patch) | |
tree | b97fef39565c4e8dd15c564cff166753eb2a19df /net/9p/trans_xen.c | |
parent | 8ee031631546cf2f7859cc69593bd60bbdd70b46 (diff) | |
download | op-kernel-dev-9523feac272ccad2ad8186ba4fcc89103754de52.zip op-kernel-dev-9523feac272ccad2ad8186ba4fcc89103754de52.tar.gz |
net/9p: Switch to wait_event_killable()
Because userspace gets Very Unhappy when calls like stat() and execve()
return -EINTR on 9p filesystem mounts. For instance, when bash is
looking in PATH for things to execute and some SIGCHLD interrupts
stat(), bash can throw a spurious 'command not found' since it doesn't
retry the stat().
In practice, hitting the problem is rare and needs a really
slow/bogged down 9p server.
Cc: stable@vger.kernel.org
Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'net/9p/trans_xen.c')
-rw-r--r-- | net/9p/trans_xen.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index 6ad3e04..325c560 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -156,8 +156,8 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req) ring = &priv->rings[num]; again: - while (wait_event_interruptible(ring->wq, - p9_xen_write_todo(ring, size)) != 0) + while (wait_event_killable(ring->wq, + p9_xen_write_todo(ring, size)) != 0) ; spin_lock_irqsave(&ring->lock, flags); |