diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-03-18 21:16:45 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-18 21:16:45 -0700 |
| commit | 0641e4fbf2f824faee00ea74c459a088d94905fd (patch) | |
| tree | 54fdd8bc2e3a928ff0f7621c06e1e604eaf0529c /net/8021q | |
| parent | 54d259d474e1fee6f6bb8f0f1360d85195199ac5 (diff) | |
| download | op-kernel-dev-0641e4fbf2f824faee00ea74c459a088d94905fd.zip op-kernel-dev-0641e4fbf2f824faee00ea74c459a088d94905fd.tar.gz | |
net: Potential null skb->dev dereference
When doing "ifenslave -d bond0 eth0", there is chance to get NULL
dereference in netif_receive_skb(), because dev->master suddenly becomes
NULL after we tested it.
We should use ACCESS_ONCE() to avoid this (or rcu_dereference())
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
| -rw-r--r-- | net/8021q/vlan_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index c0316e0..c584a0a 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -11,7 +11,7 @@ int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp, if (netpoll_rx(skb)) return NET_RX_DROP; - if (skb_bond_should_drop(skb)) + if (skb_bond_should_drop(skb, ACCESS_ONCE(skb->dev->master))) goto drop; skb->skb_iif = skb->dev->ifindex; @@ -83,7 +83,7 @@ vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp, { struct sk_buff *p; - if (skb_bond_should_drop(skb)) + if (skb_bond_should_drop(skb, ACCESS_ONCE(skb->dev->master))) goto drop; skb->skb_iif = skb->dev->ifindex; |
