summaryrefslogtreecommitdiffstats
path: root/net/6lowpan
diff options
context:
space:
mode:
authorAndrzej Hajda <a.hajda@samsung.com>2016-02-24 09:32:13 +0100
committerMarcel Holtmann <marcel@holtmann.org>2016-02-24 16:16:04 +0100
commit4c23d8745731b1b54bb8eadfc42070d7f9893b46 (patch)
treec780f7214c1254d4b30bc269717e10d677e9bb02 /net/6lowpan
parent8790404de0e5f47ef721e2ed36ebb0f2314722ac (diff)
downloadop-kernel-dev-4c23d8745731b1b54bb8eadfc42070d7f9893b46.zip
op-kernel-dev-4c23d8745731b1b54bb8eadfc42070d7f9893b46.tar.gz
6lowpan: fix error checking code
Bool variable 'fail' is always non-negative, it indicates an error if it is true. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Acked-by: Alexander Aring <aar@pengutronix.de> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/6lowpan')
-rw-r--r--net/6lowpan/iphc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/6lowpan/iphc.c b/net/6lowpan/iphc.c
index 8dd8388..06287ac 100644
--- a/net/6lowpan/iphc.c
+++ b/net/6lowpan/iphc.c
@@ -482,7 +482,7 @@ static int lowpan_uncompress_multicast_ctx_daddr(struct sk_buff *skb,
ipaddr->s6_addr[0] = 0xFF;
fail = lowpan_fetch_skb(skb, &ipaddr->s6_addr[1], 2);
fail |= lowpan_fetch_skb(skb, &ipaddr->s6_addr[12], 4);
- if (fail < 0)
+ if (fail)
return -EIO;
/* take prefix_len and network prefix from the context */
OpenPOWER on IntegriCloud