diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-03-21 16:19:41 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-04-19 16:53:20 -0400 |
commit | 1e799b673c6b82b336ab13c48b5651d511ca3000 (patch) | |
tree | 9954155b2a9bdd72e49a078418ceea6c47bcc609 /mm | |
parent | c1d519312dcdf11532fed9f99a8ecc3547ffd9d6 (diff) | |
download | op-kernel-dev-1e799b673c6b82b336ab13c48b5651d511ca3000.zip op-kernel-dev-1e799b673c6b82b336ab13c48b5651d511ca3000.tar.gz |
SUNRPC: Fix read ordering problems with req->rq_private_buf.len
We want to ensure that req->rq_private_buf.len is updated before
req->rq_received, so that call_decode() doesn't use an old value for
req->rq_rcv_buf.len.
In 'call_decode()' itself, instead of using task->tk_status (which is set
using req->rq_received) must use the actual value of
req->rq_private_buf.len when deciding whether or not the received RPC reply
is too short.
Finally ensure that we set req->rq_rcv_buf.len to zero when retrying a
request. A typo meant that we were resetting req->rq_private_buf.len in
call_decode(), and then clobbering that value with the old rq_rcv_buf.len
again in xprt_transmit().
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions