summaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorRobin H. Johnson <robbat2@gentoo.org>2006-06-12 21:50:25 +0100
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-12 13:55:52 -0700
commitcfd95a9cf58cd9e92d4c23b5ee20b07a3d121477 (patch)
tree446977d54fcf1f9e3a5c3c2f6aea1f1b1ac2f806 /mm
parent5f856e8bdcf5936c9c13cb251dae770e6eeb06b6 (diff)
downloadop-kernel-dev-cfd95a9cf58cd9e92d4c23b5ee20b07a3d121477.zip
op-kernel-dev-cfd95a9cf58cd9e92d4c23b5ee20b07a3d121477.tar.gz
[PATCH] tmpfs: time granularity fix for [acm]time going backwards
I noticed a strange behavior in a tmpfs file system the other day, while building packages - occasionally, and seemingly at random, make decided to rebuild a target. However, only on tmpfs. A file would be created, and if checked, it had a sub-second timestamp. However, after an utimes related call where sub-seconds should be set, they were zeroed instead. In the case that a file was created, and utimes(...,NULL) was used on it in the same second, the timestamp on the file moved backwards. After some digging, I found that this was being caused by tmpfs not having a time granularity set, thus inheriting the default 1 second granularity. Hugh adds: yes, we missed tmpfs when the s_time_gran mods went into 2.6.11. Unfortunately, the granularity of CURRENT_TIME, often used in filesystems, does not match the default granularity set by alloc_super. A few more such discrepancies have been found, but this is the most important to fix now. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> Acked-by: Andi Kleen <ak@suse.de> Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/shmem.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/mm/shmem.c b/mm/shmem.c
index 4c5e68e..73f7a9d 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2102,6 +2102,7 @@ static int shmem_fill_super(struct super_block *sb,
sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
sb->s_magic = TMPFS_MAGIC;
sb->s_op = &shmem_ops;
+ sb->s_time_gran = 1;
inode = shmem_get_inode(sb, S_IFDIR | mode, 0);
if (!inode)
OpenPOWER on IntegriCloud