diff options
| author | Ingo Molnar <mingo@elte.hu> | 2007-12-21 01:27:19 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2007-12-21 01:27:19 +0100 |
| commit | c0a698b7443a9fce76b0a849f06c45ac78f3b0a0 (patch) | |
| tree | ce528f832d075920f1030206a1fd016d7bf215eb /mm | |
| parent | faa4877f023bafa35239d411b160955dc0629fe9 (diff) | |
| download | op-kernel-dev-c0a698b7443a9fce76b0a849f06c45ac78f3b0a0.zip op-kernel-dev-c0a698b7443a9fce76b0a849f06c45ac78f3b0a0.tar.gz | |
x86: fix die() to not be preemptible
Andrew "Eagle Eye" Morton noticed that we use raw_local_save_flags()
instead of raw_local_irq_save(flags) in die(). This allows the
preemption of oopsing contexts - which is highly undesirable. It also
causes CONFIG_DEBUG_PREEMPT to complain, as reported by Miles Lane.
this bug was introduced via:
commit 39743c9ef717fd4f2b5583f010115c5f2482b8ae
Author: Andi Kleen <ak@suse.de>
Date: Fri Oct 19 20:35:03 2007 +0200
x86: use raw locks during oopses
- spin_lock_irqsave(&die.lock, flags);
+ __raw_spin_lock(&die.lock);
+ raw_local_save_flags(flags);
that is not a correct open-coding of spin_lock_irqsave(): both the
ordering is wrong (irqs should be disabled _first_), and the wrong
flags-saving API was used.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions
