diff options
author | Andreas Fenkart <afenkart@gmail.com> | 2014-11-08 15:33:14 +0100 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2014-11-26 14:30:55 +0100 |
commit | 326119c9923711d782e71e197429b1bab16125e1 (patch) | |
tree | 829c2379945a1e47d89955f47df9c2c6731464b9 /mm | |
parent | df206c313987bff595d2199f3bbf9b160e666b32 (diff) | |
download | op-kernel-dev-326119c9923711d782e71e197429b1bab16125e1.zip op-kernel-dev-326119c9923711d782e71e197429b1bab16125e1.tar.gz |
mmc: omap_hsmmc: remove unnecessary omap_hsmmc_slot_data indirection
omap_hsmmc supports only one slot per controller, see OMAP_MMC_MAX_SLOTS.
This unnecessary indirection leads to confusion in the omap_hsmmc driver.
For example the card_detect callback is not installed by platform code
but from the driver probe function. So it should be a field of
omap_hsmmc_host. But since it is declared under the platform slot while
the drivers struct omap_hsmmc_host has no slot abstraction, this looks
like a bug, especially when not familiar that this driver only supports
1 slot anyway.
Either we should add a slot abstraction to omap_hsmmc_host or remove
it from the platform data struct. Removed since slot multiplexing is
an un-implemented feature
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions