summaryrefslogtreecommitdiffstats
path: root/mm/page_counter.c
diff options
context:
space:
mode:
authorJosh Snyder <joshs@netflix.com>2017-12-18 16:15:10 +0000
committerIngo Molnar <mingo@kernel.org>2018-01-16 03:29:36 +0100
commitc96f5471ce7d2aefd0dda560cc23f08ab00bc65d (patch)
tree84feeca0e7b0819b55216e1fea50a3e0e79d445b /mm/page_counter.c
parenta8750ddca918032d6349adbf9a4b6555e7db20da (diff)
downloadop-kernel-dev-c96f5471ce7d2aefd0dda560cc23f08ab00bc65d.zip
op-kernel-dev-c96f5471ce7d2aefd0dda560cc23f08ab00bc65d.tar.gz
delayacct: Account blkio completion on the correct task
Before commit: e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler") delayacct_blkio_end() was called after context-switching into the task which completed I/O. This resulted in double counting: the task would account a delay both waiting for I/O and for time spent in the runqueue. With e33a9bba85a8, delayacct_blkio_end() is called by try_to_wake_up(). In ttwu, we have not yet context-switched. This is more correct, in that the delay accounting ends when the I/O is complete. But delayacct_blkio_end() relies on 'get_current()', and we have not yet context-switched into the task whose I/O completed. This results in the wrong task having its delay accounting statistics updated. Instead of doing that, pass the task_struct being woken to delayacct_blkio_end(), so that it can update the statistics of the correct task. Signed-off-by: Josh Snyder <joshs@netflix.com> Acked-by: Tejun Heo <tj@kernel.org> Acked-by: Balbir Singh <bsingharora@gmail.com> Cc: <stable@vger.kernel.org> Cc: Brendan Gregg <bgregg@netflix.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-block@vger.kernel.org Fixes: e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler") Link: http://lkml.kernel.org/r/1513613712-571-1-git-send-email-joshs@netflix.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'mm/page_counter.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud