summaryrefslogtreecommitdiffstats
path: root/mm/oom_kill.c
diff options
context:
space:
mode:
authorDavid Rientjes <rientjes@google.com>2010-08-09 17:18:46 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-08-09 20:44:56 -0700
commit74ab7f1d3f22ccb02f8b14f1f2375416b1ab0adb (patch)
tree94f7e6b0e77fe11f200941f97d1fc895dc950fde /mm/oom_kill.c
parentc55db95788a2a55a77f5a3ced1e59578710440b2 (diff)
downloadop-kernel-dev-74ab7f1d3f22ccb02f8b14f1f2375416b1ab0adb.zip
op-kernel-dev-74ab7f1d3f22ccb02f8b14f1f2375416b1ab0adb.tar.gz
oom: improve commentary in dump_tasks()
The comments in dump_tasks() should be updated to be more clear about why tasks are filtered and how they are filtered by its argument. An unnecessary comment concerning a check for is_global_init() is removed since it isn't of importance. Suggested-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David Rientjes <rientjes@google.com> Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Balbir Singh <balbir@in.ibm.com> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/oom_kill.c')
-rw-r--r--mm/oom_kill.c11
1 files changed, 3 insertions, 8 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 5285da9..ef4ed4a 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -323,7 +323,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
/**
* dump_tasks - dump current memory state of all system tasks
- * @mem: target memory controller
+ * @mem: current's memory controller, if constrained
*
* Dumps the current memory state of all system tasks, excluding kernel threads.
* State information includes task's pid, uid, tgid, vm size, rss, cpu, oom_adj
@@ -342,11 +342,6 @@ static void dump_tasks(const struct mem_cgroup *mem)
printk(KERN_INFO "[ pid ] uid tgid total_vm rss cpu oom_adj "
"name\n");
for_each_process(p) {
- /*
- * We don't have is_global_init() check here, because the old
- * code do that. printing init process is not big matter. But
- * we don't hope to make unnecessary compatibility breaking.
- */
if (p->flags & PF_KTHREAD)
continue;
if (mem && !task_in_mem_cgroup(p, mem))
@@ -355,8 +350,8 @@ static void dump_tasks(const struct mem_cgroup *mem)
task = find_lock_task_mm(p);
if (!task) {
/*
- * Probably oom vs task-exiting race was happen and ->mm
- * have been detached. thus there's no need to report
+ * This is a kthread or all of p's threads have already
+ * detached their mm's. There's no need to report
* them; they can't be oom killed anyway.
*/
continue;
OpenPOWER on IntegriCloud