summaryrefslogtreecommitdiffstats
path: root/mm/migrate.c
diff options
context:
space:
mode:
authorMel Gorman <mgorman@suse.de>2013-10-07 11:28:45 +0100
committerIngo Molnar <mingo@kernel.org>2013-10-09 12:39:44 +0200
commit8191acbd30c73e45c24ad16c372e0b42cc7ac8f8 (patch)
tree1c558203ad1f7e141ef3e587d5d3d846ac82e0ec /mm/migrate.c
parentb8916634b77bffb233d8f2f45703c80343457cc1 (diff)
downloadop-kernel-dev-8191acbd30c73e45c24ad16c372e0b42cc7ac8f8.zip
op-kernel-dev-8191acbd30c73e45c24ad16c372e0b42cc7ac8f8.tar.gz
mm: numa: Sanitize task_numa_fault() callsites
There are three callers of task_numa_fault(): - do_huge_pmd_numa_page(): Accounts against the current node, not the node where the page resides, unless we migrated, in which case it accounts against the node we migrated to. - do_numa_page(): Accounts against the current node, not the node where the page resides, unless we migrated, in which case it accounts against the node we migrated to. - do_pmd_numa_page(): Accounts not at all when the page isn't migrated, otherwise accounts against the node we migrated towards. This seems wrong to me; all three sites should have the same sementaics, furthermore we should accounts against where the page really is, we already know where the task is. So modify all three sites to always account; we did after all receive the fault; and always account to where the page is after migration, regardless of success. They all still differ on when they clear the PTE/PMD; ideally that would get sorted too. Signed-off-by: Mel Gorman <mgorman@suse.de> Reviewed-by: Rik van Riel <riel@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1381141781-10992-8-git-send-email-mgorman@suse.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'mm/migrate.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud