summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-11-04 17:10:26 +0100
committerDavid S. Miller <davem@davemloft.net>2013-11-04 15:27:08 -0500
commitcc0ac1999589c9f713550adde85a09b0dbb75d86 (patch)
tree8d2abcf4fdee4db65750cccafddaba5f1a05ef2d /lib
parentcea80ea8d2a4c646f240a8fd6ece5c8e7bc969d3 (diff)
downloadop-kernel-dev-cc0ac1999589c9f713550adde85a09b0dbb75d86.zip
op-kernel-dev-cc0ac1999589c9f713550adde85a09b0dbb75d86.tar.gz
lib: crc32: conditionally resched when running testcases
Fengguang reports that when crc32 selftests are running on startup, on some e.g. 32bit systems, we can get a CPU stall like "INFO: rcu_sched self-detected stall on CPU { 0} (t=2101 jiffies g=4294967081 c=4294967080 q=41)". As this is not intended, add a cond_resched() at the end of a test case to fix it. Introduced by efba721f63 ("lib: crc32: add test cases for crc32{, c}_combine routines"). Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
-rw-r--r--lib/crc32.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/crc32.c b/lib/crc32.c
index 69dd124..3a1dfa8 100644
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -29,6 +29,7 @@
#include <linux/crc32.h>
#include <linux/module.h>
#include <linux/types.h>
+#include <linux/sched.h>
#include "crc32defs.h"
#if CRC_LE_BITS > 8
@@ -1054,6 +1055,7 @@ static int __init crc32c_combine_test(void)
crc_full == test[i].crc32c_le))
errors++;
runs++;
+ cond_resched();
}
}
@@ -1147,6 +1149,7 @@ static int __init crc32_combine_test(void)
crc_full == test[i].crc_le))
errors++;
runs++;
+ cond_resched();
}
}
OpenPOWER on IntegriCloud