diff options
| author | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-04-03 14:38:53 -0400 |
|---|---|---|
| committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-04-06 08:56:51 -0400 |
| commit | 1e6338cfb50e244c445ad7d891b35385bd0ee757 (patch) | |
| tree | a705089ef2d001966b5eb65f11ca39b8bce41fc3 /lib | |
| parent | b28d7b2dc27f0eef1ae608b49d6860f2463910f1 (diff) | |
| download | op-kernel-dev-1e6338cfb50e244c445ad7d891b35385bd0ee757.zip op-kernel-dev-1e6338cfb50e244c445ad7d891b35385bd0ee757.tar.gz | |
vsprintf: Do not preprocess non-dereferenced pointers for bprintf (%px and %pK)
Commit 841a915d20c7b2 ("printf: Do not have bprintf dereference pointers")
would preprocess various pointers that are dereferenced in the bprintf()
because the recording and printing are done at two different times. Some
pointers stayed dereferenced in the ring buffer because user space could
handle them (namely "%pS" and friends). Pointers that are not dereferenced
should not be processed immediately but instead just saved directly.
Cc: stable@vger.kernel.org
Fixes: 841a915d20c7b2 ("printf: Do not have bprintf dereference pointers")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/vsprintf.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index d7a708f..89f8a4a 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -2591,6 +2591,8 @@ int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args) case 's': case 'F': case 'f': + case 'x': + case 'K': save_arg(void *); break; default: @@ -2765,6 +2767,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf) case 's': case 'F': case 'f': + case 'x': + case 'K': process = true; break; default: |
