diff options
| author | Hugh Dickins <hugh@veritas.com> | 2008-07-28 15:46:19 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-28 16:30:20 -0700 |
| commit | 14fcc23fdc78e9d32372553ccf21758a9bd56fa1 (patch) | |
| tree | 594fc0e0e85c03205ba2d80a4b4e0a8fc6ffaa8a /lib | |
| parent | ca5b172bd2b2fe489e7ba11cedd46ddf772d132f (diff) | |
| download | op-kernel-dev-14fcc23fdc78e9d32372553ccf21758a9bd56fa1.zip op-kernel-dev-14fcc23fdc78e9d32372553ccf21758a9bd56fa1.tar.gz | |
tmpfs: fix kernel BUG in shmem_delete_inode
SuSE's insserve initscript ordering program hits kernel BUG at mm/shmem.c:814
on 2.6.26. It's using posix_fadvise on directories, and the shmem_readpage
method added in 2.6.23 is letting POSIX_FADV_WILLNEED allocate useless pages
to a tmpfs directory, incrementing i_blocks count but never decrementing it.
Fix this by assigning shmem_aops (pointing to readpage and writepage and
set_page_dirty) only when it's needed, on a regular file or a long symlink.
Many thanks to Kel for outstanding bugreport and steps to reproduce it.
Reported-by: Kel Modderman <kel@otaku42.de>
Tested-by: Kel Modderman <kel@otaku42.de>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: <stable@kernel.org> [2.6.25.x, 2.6.26.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions
