diff options
author | Dmitriy Monakhov <dmonakhov@sw.ru> | 2007-05-08 00:25:34 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-08 11:15:01 -0700 |
commit | fedee54d8f12cdfde299f181fec5c62b0c647ad6 (patch) | |
tree | 815a5de82d0c242bb1e6a012a237d0715c3b08af /lib | |
parent | 753e9c5cd9b123156152c66c816f751954b15e53 (diff) | |
download | op-kernel-dev-fedee54d8f12cdfde299f181fec5c62b0c647ad6.zip op-kernel-dev-fedee54d8f12cdfde299f181fec5c62b0c647ad6.tar.gz |
ext3: dirindex error pointer issues
- ext3_dx_find_entry() exit with out setting proper error pointer
- do_split() exit with out setting proper error pointer
it is realy painful because many callers contain folowing code:
de = do_split(handle,dir, &bh, frame, &hinfo, &retval);
if (!(de))
return retval;
<<< WOW retval wasn't changed by do_split(), so caller failed
<<< but return SUCCESS :)
- Rearrange do_split() error path. Current error path is realy ugly, all
this up and down jump stuff doesn't make code easy to understand.
[dmonakhov@sw.ru: fix annoying fake error messages]
Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
Cc: Andreas Dilger <adilger@clusterfs.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions