summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-09-21 19:21:51 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-10-05 04:49:54 +0100
commit1f35d04a02a652f14566f875aef3a6f2af4cb77b (patch)
treed4de9f8e5f4aa03b14f4a02905126673b8279f98 /lib
parenta785ce9c90bc7d73b5cae4388641b310948509cb (diff)
downloadop-kernel-dev-1f35d04a02a652f14566f875aef3a6f2af4cb77b.zip
op-kernel-dev-1f35d04a02a652f14566f875aef3a6f2af4cb77b.tar.gz
devres: fix a for loop bounds check
The iomap[] array has PCIM_IOMAP_MAX (6) elements and not DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. It may be that the "if (!(mask & (1 << i)))" check means we never actually go past the end of the array in real life. Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/devres.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/devres.c b/lib/devres.c
index f13a246..8c85672 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
if (!iomap)
return;
- for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+ for (i = 0; i < PCIM_IOMAP_MAX; i++) {
if (!(mask & (1 << i)))
continue;
OpenPOWER on IntegriCloud