diff options
| author | Gayatri Kammela <gayatri.kammela@intel.com> | 2016-09-26 14:37:38 -0700 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2016-09-26 16:18:21 -0700 |
| commit | 099b548c429217a8306adbd1552d326615c9b903 (patch) | |
| tree | 5494f9f5ec8ff08f18ab1f5bfc935bbd7f792cc1 /lib | |
| parent | 30c8946566f32493f7f1143437319c42c8a542e9 (diff) | |
| download | op-kernel-dev-099b548c429217a8306adbd1552d326615c9b903.zip op-kernel-dev-099b548c429217a8306adbd1552d326615c9b903.tar.gz | |
raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays
Specifying the aligned attributes to the char data[NDISKS][PAGE_SIZE],
char recovi[PAGE_SIZE] and char recovi[PAGE_SIZE] arrays, so that all
malloc memory is page boundary aligned.
Without these alignment attributes, the test causes a segfault in
userspace when the NDISKS are changed to 4 from 16.
The RAID stripes will be page aligned anyway, so we want to test what
the kernel actually will execute.
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Yu-cheng Yu <yu-cheng.yu@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
Reviewed-by: H. Peter Anvin <hpa@linux.intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/raid6/test/test.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/raid6/test/test.c b/lib/raid6/test/test.c index 3bebbab..b07f4d8 100644 --- a/lib/raid6/test/test.c +++ b/lib/raid6/test/test.c @@ -21,12 +21,13 @@ #define NDISKS 16 /* Including P and Q */ -const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256))); +const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); struct raid6_calls raid6_call; char *dataptrs[NDISKS]; -char data[NDISKS][PAGE_SIZE]; -char recovi[PAGE_SIZE], recovj[PAGE_SIZE]; +char data[NDISKS][PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); +char recovi[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); +char recovj[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); static void makedata(int start, int stop) { |
