diff options
author | Tejun Heo <tj@kernel.org> | 2013-02-27 17:05:10 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-27 19:10:21 -0800 |
commit | 7175c61cc6b8e701441e79ef048c11ae97293463 (patch) | |
tree | 515c24958e871c550b3b7f0c2356b4909ba83d61 /lib/swiotlb.c | |
parent | 0ffc2a9c8072969253a20821c2c733a2cbb4c7c7 (diff) | |
download | op-kernel-dev-7175c61cc6b8e701441e79ef048c11ae97293463.zip op-kernel-dev-7175c61cc6b8e701441e79ef048c11ae97293463.tar.gz |
idr: explain WARN_ON_ONCE() on negative IDs out-of-range ID
Until recently, when an negative ID is specified, idr functions used to
ignore the sign bit and proceeded with the operation with the rest of
bits, which is bizarre and error-prone. The behavior recently got changed
so that negative IDs are treated as invalid but we're triggering
WARN_ON_ONCE() on negative IDs just in case somebody was depending on the
sign bit being ignored, so that those can be detected and fixed easily.
We only need this for a while. Explain why WARN_ON_ONCE()s are there and
that they can be removed later.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/swiotlb.c')
0 files changed, 0 insertions, 0 deletions