diff options
author | Matthew Wilcox <willy@linux.intel.com> | 2016-05-20 17:02:23 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-05-20 17:58:30 -0700 |
commit | 7b60e9ad59a31dd98c2f7ef841e2882c2b0e0f3b (patch) | |
tree | cca917997c4005d2607172a9389b63172feab0ca /lib/oid_registry.c | |
parent | 858299544efcf2577511bb018b9e73637ac71a2f (diff) | |
download | op-kernel-dev-7b60e9ad59a31dd98c2f7ef841e2882c2b0e0f3b.zip op-kernel-dev-7b60e9ad59a31dd98c2f7ef841e2882c2b0e0f3b.tar.gz |
radix-tree: fix multiorder BUG_ON in radix_tree_insert
These BUG_ON tests are to ensure that all the tags are clear when
inserting a new entry. If we insert a multiorder entry, we'll end up
looking at the tags for a different node, and so the BUG_ON can end up
triggering spuriously.
Also, we now have three tags, not two, so check all three are clear, and
check all the root tags with a single call to BUG_ON since the bits are
stored contiguously.
Include a test-case to ensure this problem does not reoccur.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Kirill Shutemov <kirill.shutemov@linux.intel.com>
Cc: Jan Kara <jack@suse.com>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/oid_registry.c')
0 files changed, 0 insertions, 0 deletions