diff options
| author | James Bottomley <James.Bottomley@SteelEye.com> | 2005-08-19 09:14:01 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 16:03:13 -0700 |
| commit | d856f1e337782326c638c70c0b4df2b909350dec (patch) | |
| tree | 15c070e3909cbd260b2616001f0a6dde4a0c24fa /lib/klist.c | |
| parent | fef6ec8dd96205fb22e3cfe2e4abd69d89413631 (diff) | |
| download | op-kernel-dev-d856f1e337782326c638c70c0b4df2b909350dec.zip op-kernel-dev-d856f1e337782326c638c70c0b4df2b909350dec.tar.gz | |
[PATCH] klist: fix klist to have the same klist_add semantics as list_head
at the moment, the list_head semantics are
list_add(node, head)
whereas current klist semantics are
klist_add(head, node)
This is bound to cause confusion, and since klist is the newcomer, it
should follow the list_head semantics.
I also added missing include guards to klist.h
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'lib/klist.c')
| -rw-r--r-- | lib/klist.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/klist.c b/lib/klist.c index 738ab81..a70c836 100644 --- a/lib/klist.c +++ b/lib/klist.c @@ -79,11 +79,11 @@ static void klist_node_init(struct klist * k, struct klist_node * n) /** * klist_add_head - Initialize a klist_node and add it to front. - * @k: klist it's going on. * @n: node we're adding. + * @k: klist it's going on. */ -void klist_add_head(struct klist * k, struct klist_node * n) +void klist_add_head(struct klist_node * n, struct klist * k) { klist_node_init(k, n); add_head(k, n); @@ -94,11 +94,11 @@ EXPORT_SYMBOL_GPL(klist_add_head); /** * klist_add_tail - Initialize a klist_node and add it to back. - * @k: klist it's going on. * @n: node we're adding. + * @k: klist it's going on. */ -void klist_add_tail(struct klist * k, struct klist_node * n) +void klist_add_tail(struct klist_node * n, struct klist * k) { klist_node_init(k, n); add_tail(k, n); |
