diff options
author | Daniel J Blueman <daniel.blueman@gmail.com> | 2010-06-01 14:06:13 +0100 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2010-06-23 06:50:44 -0700 |
commit | f3b577dec1f2ce32d2db6d2ca6badff7002512af (patch) | |
tree | c9d5d84b2d3e4ae1251f69932a526367a2bac7fa /lib/idr.c | |
parent | 7e27d6e778cd87b6f2415515d7127eba53fe5d02 (diff) | |
download | op-kernel-dev-f3b577dec1f2ce32d2db6d2ca6badff7002512af.zip op-kernel-dev-f3b577dec1f2ce32d2db6d2ca6badff7002512af.tar.gz |
rcu: apply RCU protection to wake_affine()
The task_group() function returns a pointer that must be protected
by either RCU, the ->alloc_lock, or the cgroup lock (see the
rcu_dereference_check() in task_subsys_state(), which is invoked by
task_group()). The wake_affine() function currently does none of these,
which means that a concurrent update would be within its rights to free
the structure returned by task_group(). Because wake_affine() uses this
structure only to compute load-balancing heuristics, there is no reason
to acquire either of the two locks.
Therefore, this commit introduces an RCU read-side critical section that
starts before the first call to task_group() and ends after the last use
of the "tg" pointer returned from task_group(). Thanks to Li Zefan for
pointing out the need to extend the RCU read-side critical section from
that proposed by the original patch.
Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'lib/idr.c')
0 files changed, 0 insertions, 0 deletions