diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2013-12-05 22:22:04 +0100 |
---|---|---|
committer | Brian Norris <computersforpeace@gmail.com> | 2014-01-14 17:22:37 -0800 |
commit | 05f7835975dad6b3b517f9e23415985e648fb875 (patch) | |
tree | ed86b42f8dc1c6a5704728c075abb92f6a1e4bf0 /kernel | |
parent | e2e6b7b7d64baeac1c38fa5eb0d3ec85f3d123f5 (diff) | |
download | op-kernel-dev-05f7835975dad6b3b517f9e23415985e648fb875.zip op-kernel-dev-05f7835975dad6b3b517f9e23415985e648fb875.tar.gz |
mtd: nand: don't use {read,write}_buf for 8-bit transfers
According to the Open NAND Flash Interface Specification (ONFI) Revision
3.1 "Parameters are always transferred on the lower 8-bits of the data
bus." for the Get Features and Set Features commands.
So using read_buf and write_buf is wrong for 16-bit wide nand chips as
they use I/O[15:0]. The Get Features command is easily fixed using 4
times the read_byte callback. For Set Features implement a new
overwritable callback "write_byte". Still I expect the default to work
just fine for all controllers and making it overwriteable was just done
for symmetry.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[Brian: fixed warning]
Tested-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions