diff options
| author | Alexei Starovoitov <ast@plumgrid.com> | 2014-10-20 14:54:57 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-10-21 21:43:46 -0400 |
| commit | 32bf08a6257b9c7380dcd040af3c0858eee3ef05 (patch) | |
| tree | b5928993937cb9bc095f6c3e0393eb63f6471308 /kernel | |
| parent | 78fd1d0ab072d4d9b5f0b7c14a1516665170b565 (diff) | |
| download | op-kernel-dev-32bf08a6257b9c7380dcd040af3c0858eee3ef05.zip op-kernel-dev-32bf08a6257b9c7380dcd040af3c0858eee3ef05.tar.gz | |
bpf: fix bug in eBPF verifier
while comparing for verifier state equivalency the comparison
was missing a check for uninitialized register.
Make sure it does so and add a testcase.
Fixes: f1bca824dabb ("bpf: add search pruning optimization to verifier")
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/bpf/verifier.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 801f5f3..9f81818 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1409,7 +1409,8 @@ static bool states_equal(struct verifier_state *old, struct verifier_state *cur) if (memcmp(&old->regs[i], &cur->regs[i], sizeof(old->regs[0])) != 0) { if (old->regs[i].type == NOT_INIT || - old->regs[i].type == UNKNOWN_VALUE) + (old->regs[i].type == UNKNOWN_VALUE && + cur->regs[i].type != NOT_INIT)) continue; return false; } |
